-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC GH3508 (bis) added basic documentation of google analytics in remot... #8835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
actually if you would add a release note (in Enhancements) in v0.15.2, with a pointer to the docs (e.g. see here)....then people will know about the new docs. thanks |
56c36f2
to
726d7ad
Compare
Added entry in whatsnew for v15.0.2. |
For the rest, looks good to me! |
merged via 9dd675b thanks! |
@benoitpointet can you run this PR and see if it removes the warnings that were previously generated. lmk |
Tested, it does indeed. It however does not remove the index_col bug described in #8773. |
k thanks... #8773 is not a bug, or did this use to work? (e.g. has the format changed)? The user needs to specify the |
it used to work without having to provide the index_col argument. |
if you want to somehow infer that the index_col is 0 that would be great! (e.g if Ideally would have tests for this..... |
I'm unsure about hacking the If you look at the behaviour of the |
added the GA doc to the correct file: "remote_data.rst"
closes #3508