TST: Raise remote data error if no expiry dates are found (Options) #8763
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to replicate that issue if I set the expiry dates from yahoo to an empty list. This raises RemoteDataError in that case, so skips tests. Does this need a mention in what's new? |
|
yes, give a mention in bug fixes with the issue. lmk when you repush |
jreback
added
Data Reader
Testing
davidastephens
force-pushed
the
issue8761
branch
from
9e174e5 to
a8c4569
Compare
|
@jreback Added comment in bug fixes. Green and good to go. |
jreback
added a commit
that referenced
this pull request
Nov 9, 2014
TST: Raise remote data error if no expiry dates are found (Options)
|
beautiful! thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8761.