BUG: Fix io.data.Options quote time for DST. #8741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidastephens
force-pushed
the
issue8612
branch
from
54fb691 to
104a053
Compare
|
The doc errors are indeed fixed! Is it possible to include a test for what you fixed? |
|
@dstephens99 also add this issue number to the release notes (just put it after the original issue #8631) |
Added new test for live quote time and updated the second test html so that it uses a DST sample. DOC: Add issue to release notes, note in tests.
davidastephens
force-pushed
the
issue8612
branch
from
104a053 to
bddec83
Compare
|
@jorisvandenbossche |
|
@jreback I added the issue number to the release notes. |
|
@dstephens99 ah, I hadn't noticed the change in the html file, ok then! |
jreback
added a commit
that referenced
this pull request
Nov 7, 2014
BUG: Fix io.data.Options quote time for DST.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the second test html so that it uses a DST sample.
Changed failure to get quote time from raising RemoteDataError to setting to np.nan
@jorisvandenbossche This fixes the doc error you noted on #8631