Skip to content

ENH: axvlines - boolean option to parallel_coordinates plot #8513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bjacobowski
Copy link
Contributor

Determines whether vertical lines will be added to parallel_coordinates plot. I was using parallel coordinates to make a seasonality chart - plotting years on top of each other (days/months of year on x-axis). With that many xticks, the vertical lines were overwhelming. It's possible to remove the lines after the fact, but without specific line identifiers, it isn't a straight forward process. However, preventing them from being added is a one-liner...

@bjacobowski bjacobowski changed the title axvlines: boolean option to parallel_coordinates plot ENH: axvlines - boolean option to parallel_coordinates plot Oct 8, 2014
@jreback
Copy link
Contributor

jreback commented Oct 9, 2014

@TomAugspurger ?

@jreback jreback added the Visualization plotting label Oct 9, 2014
@jreback jreback added this to the 0.15.1 milestone Oct 13, 2014
@jreback
Copy link
Contributor

jreback commented Oct 25, 2014

@TomAugspurger ?

@TomAugspurger
Copy link
Contributor

Sorry I meant to reply earlier. I'll take a look soonish. I'm a bit hesitant just because our parrallel coordinates habdling isn't the best. But I'll get back on this

@TomAugspurger
Copy link
Contributor

@bjacobowski ok, sorry it took me so long to get to this.

Could you post some code with small example of what you were doing? Also a before and after picture would be great.

We'll also need a test in pandas/tests/test_graphics.py. Just something simple like the length of the .lines attribute on the returned axes being equal to the number of lines (so no extra vlines). Also a test that the vlines are added (by default).

That said pandas is trying to move its focus away from plotting since there are so many great python vis libraries. This is so minor that I'm happy to accept it. But if you're interested you could see if seaborn or bokeh or ggplot would accept a PR for parallel coordinate support.

@bjacobowski
Copy link
Contributor Author

@TomAugspurger Here's a basic example:
parallel coordinates - axvlines example
seasonality.py

@jreback
Copy link
Contributor

jreback commented Nov 29, 2014

@TomAugspurger what are we doing with this?

@TomAugspurger
Copy link
Contributor

Let's get it merged with the understanding that any proper implementation of parallel coordinates should go into seaborn or ggplot or bokeh.

@bjacobowski would you mind adding a release note to doc/source/whatsnew/v0.15.2?

@bjacobowski
Copy link
Contributor Author

@TomAugspurger done

@TomAugspurger
Copy link
Contributor

@bjacobowski can you try to rebase against master and squash this down to one commit. For some reason it's trying to commit the entire whatsnew/v0.15.2.txt. Checkout the wiki or post if you have any trouble.

@bjacobowski bjacobowski force-pushed the parallel_coordinates-axvlines branch from dfc63b4 to b9d2008 Compare December 5, 2014 15:31
@bjacobowski
Copy link
Contributor Author

@TomAugspurger that work?

@bjacobowski bjacobowski closed this Dec 5, 2014
@bjacobowski bjacobowski reopened this Dec 5, 2014
@TomAugspurger
Copy link
Contributor

Perfect. Just going to wait until Travis is green.

TomAugspurger pushed a commit that referenced this pull request Dec 5, 2014
ENH: axvlines - boolean option to parallel_coordinates plot
@TomAugspurger TomAugspurger merged commit 4ab5409 into pandas-dev:master Dec 5, 2014
@TomAugspurger
Copy link
Contributor

Thanks @bjacobowski

@bjacobowski bjacobowski deleted the parallel_coordinates-axvlines branch September 3, 2015 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants