BUG: Work-around openpyxl-2.1.0 NumberFormat removal #8352
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok! let me know when green (then will leave the issue open). If you have a more complete fix later can merge (other wise can simply document / put in some versioning checks) |
jreback
added
Compat
|
@neirbowj saw your comment. I'll watch for the green. Have a nice flight! |
|
@neirbowj - thanks for taking the time to work on this fix! I was really On Mon, Sep 22, 2014 at 7:47 AM, jreback [email protected] wrote:
|
|
closing in favor of #8356 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8342. This patch should allow all tests to pass with any supported openpyxl v1, and with openpyxl 2.1.0. Consider this an interim measure, not a complete fix.