TST: Fixed precision test error for read_csv #8335
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
let me try |
|
didn't fix. If want to setup a windows build, be my guest (though its a bit of a PITA): https://github.com/pydata/pandas/wiki/Building-On-Windows Could skip on windows / change the check as well. |
mdmueller
force-pushed
the
fix-precision-test
branch
from
6967c96 to
94b18cd
Compare
|
To me this is really strange, as I can't think of the reason why the converters should be at all platform-dependent (probably the same issue as in #8044). For the moment I amended this commit to a |
|
sure that's fine windows is just odd |
|
closed by 0005e0f just stuck it in, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully fix #8324.
@jreback