Skip to content

DOC: setuptools is a required runtime dependency #8107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

DOC: setuptools is a required runtime dependency #8107

wants to merge 1 commit into from

Conversation

cgohlke
Copy link
Contributor

@cgohlke cgohlke commented Aug 24, 2014

@jreback
Copy link
Contributor

jreback commented Aug 24, 2014

hmm I think easier to simply eliminate the need for pkg_resources - not sure why this is in their in the first place

@jreback
Copy link
Contributor

jreback commented Aug 24, 2014

cc @jacobschaer

can u just do gflags.version (or similar)?

@jreback jreback added this to the 0.15.0 milestone Aug 24, 2014
@jreback
Copy link
Contributor

jreback commented Sep 10, 2014

cc @jacobschaer ?

@jacobschaer
Copy link
Contributor

@jreback I seem to recall Google was doing something weird with their version strings before. I'd have to look to see if that's still the case. Isn't setuptools a requirement for pandas anyways? @sean-schaefer

@jreback
Copy link
Contributor

jreback commented Sep 11, 2014

@jacobschaer setuptools is only a requirement of building from source. not a run-time (on windows).

Any way to eliminate its usage (e.g. using LooseVersion)?

@jreback
Copy link
Contributor

jreback commented Sep 19, 2014

@jacobschaer ?

@jacobschaer
Copy link
Contributor

Was looking into this - I'm having some account issues with GBQ for integration testing, but it looks like using:

if LooseVersion(apiclient.__version__ >= '1.2.0'):

works. However, that's only part of the google-api-python-client package. As for gflags, a quick look shows no easy way to identify it's version programatically. However, in light of #8327, it may no longer be needed...

@jreback
Copy link
Contributor

jreback commented Sep 20, 2014

@jacobschaer

I don't mind that setup tools is require for gbq
just don't want it necessary on main importing of pandas
can u move this detection so that it would fail w/ o setuptools ?
and then add setuptools to install.rst

@jreback
Copy link
Contributor

jreback commented Sep 26, 2014

@jacobschaer status?

@jacobschaer
Copy link
Contributor

During testing, I exceed a rate limiter in BQ (my bad - had two tests running at once on accident). I'll re-run the integration test later. I haven't tried removing setuptools from the virtual enviroment, but I can't see why this wouldn't work. #8409

@jacobschaer
Copy link
Contributor

Integration test finally passed locally. Still need to validate that it actually solved the problem... anyone want to try it? :D

@jreback
Copy link
Contributor

jreback commented Sep 29, 2014

closing in favor of #8409

@jreback jreback closed this Sep 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants