Fix testing multiindex dtypes in assert_frame_equal and assert_series_equal #8042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
let's see if anything breaks (on the regular tests!) |
|
Sounds good (at least locally on my end all the tests passed) |
jreback
added a commit
that referenced
this pull request
Aug 15, 2014
…ex-dtypes Fix testing multiindex dtypes in assert_frame_equal and assert_series_equal
|
nice addition! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
assert_frame_equalorassert_series_equalin the presence of a multiindex, the dtype of the index as a whole isobject. Hence, there is no checking that the dtypes of the individual levels match. We now iterate through the levels.