DOC/CLN: Cleanups plotting.py #8037
Conversation
| return plot_obj.axes[0] | ||
|
|
||
|
|
||
| df_kind = """kind : {'line', 'bar', 'barh', 'hist', 'kde', 'density', 'area', 'pie', scatter', 'hexbin'} |
There was a problem hiding this comment.
This is list getting rather long ..
What do you think of just doing kind : string, default 'line' ? As all possibilities are also listed underneath? (and maybe in that case put them in quotes in the list like - 'bar' : vertical bar plot, then it is also clear the those strings are the options)
|
@sinhrks Docstrings are looking nice! Made some comments (and note that a lot of them are comments on the existing docstrings, but thought was a good opportunity to look at that too) I did not yet really look at the actual code refactor, but the only think I was worrying a bit is: you changed the order of keyword arguments, that is right? Now you put |
|
Thanks, fixed the points. And agreed to hold |
sinhrks
force-pushed
the
plot_cln
branch
3 times, most recently
from
894d9a0 to
89f51b8
Compare
|
@sinhrks Can you rebase this? @TomAugspurger Can you also have a look? |
|
Yep, rebased. |
| klass_unique=series_unique, klass_note=series_note) | ||
|
|
||
| _shared_docs['plot'] = """ | ||
| Make plots of %(klass)s with the index on the x-axis |
There was a problem hiding this comment.
Depending on the options, the index will not be on the x-axis. You can probably just leave this off and have Make plots of %(klass)s
|
This cleanup really needed to be done, thanks @sinhrks. Just had a few inline comments. There's also a few lines in the docstring that are longer that 80 characters, but if this is a formatting thing so that it looks nice in the REPL, then no problem. |
sinhrks
force-pushed
the
plot_cln
branch
3 times, most recently
from
a7251d5 to
de6d161
Compare
|
@sinhrks pls rebase |
|
@sinhrks I can merge once you get a chance to rebase. Let me know. |
|
@sinhrks status? |
|
@sinhrks will you have a chance to do this in the next couple days? If not I can cherry pick things. I'd like to get all the vis PRs done by tomorrow. |
|
@TomAugspurger let's either cherry-pick or push to 0.15.1 whatever you can do in next couple of days |
DataFrame.plotandSeries.plotshould have consistent docstring except differences.