COMPAT: change pytables to use 3.0.0 API (GH7990) #7994
Conversation
|
nice: - is bigger than + |
|
that's a first! |
|
@cpcloud @jorisvandenbossche comments? |
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| try: | |||
| import numexpr as ne | |||
| _NUMEXPR_INSTALLED = ne.__version__ >= LooseVersion('2.0') | |||
| _NUMEXPR_INSTALLED = ne.__version__ >= LooseVersion('2.1') | |||
There was a problem hiding this comment.
might be nice here to warn if the installed version is < 2.1
There was a problem hiding this comment.
tho i could see why this being transparent is useful ... just treat it as not installed if the version is incompat...
however as a user of pandas i would like to know that i won't get any numexpr optims when i'm using pandas
There was a problem hiding this comment.
Hmm, ok that makes sense I gues.
There was a problem hiding this comment.
I mean not a huge deal if you don't like it then don't have to do it.
|
minor comments. otherwise looks good |
|
Would this be annoying then? look at the tests |
|
I think it is a useful and informative message, unless you don't bother to use numexpr (and it is eg installed in your distribution) ... then it can become annoying (but that is always like this with warnings no?). |
|
What is reason for upgrading the required versions? Is it only testing? (that we have to test less versions?) Because both PyTables 3 and Numexpr 2.1 are only 1 to 1.5 year old. |
|
@jorisvandenbossche yes < 2.1 is pretty old at this point. The reason for the changes is motiviated by using conda for ci, as it doesn't support these (pretty old) versions. And we have to do this at some point before 3.2 PyTables is out (maybe end of year). As the api will start showing a different kind of warning. (it shows DeprecationWarning on all tests atm, but we are suppressing this). I don't think this is really a big deal. 99% of users dumped 2.4 as soon as 3.0.0 came out because it supports py3 (and had a lot of bug fixes). (and its backward compatible). |
|
@jreback OK, sounds reasonable |
COMPAT: change pytables to use 3.0.0 API (GH7990)
|
@jreback I got the warning :-) |
|
hmm, was 2.0.0, now its 2.1, ok easy to fix |
|
Thanks! |
closes #7990