Skip to content

BUG/API: Consistency in .where() when setting with None for both inplace in a Series (GH7939) #7940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Aug 5, 2014

closes #7939

…ace=True and inplace=False for a Series (GH7939)
@jreback jreback added this to the 0.15.0 milestone Aug 5, 2014
@jreback jreback closed this Aug 5, 2014
@jorisvandenbossche
Copy link
Member

@jreback not fully clear, but which of the two behaviours is it after this PR? The inplace (convert to NaN) or the non-inplace (keep None) ?

@jreback
Copy link
Contributor Author

jreback commented Aug 6, 2014

I closed this because not really sure what (if anything) to do at this point. You can see the reference discussion on the issue. None is kind of a mess. But changing anything is extremely tricky as their really aren't enough tests to validate current or proposed behavior. and it is often ambiguous on what to do.

np.nan is the missing value indicator, so None should NOT be treated specially, but it IS in some places for convience. It is a can of worms.

@jorisvandenbossche
Copy link
Member

ah, yes, I thought this was merged, my mistake.
I know it is a mess, I just added some more of it :-) (#7939 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent treatment of None with .where() and inplace
2 participants