Skip to content

BUG: fix greedy date parsing in read_html #7851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2014
+1,797 −41
Merged

BUG: fix greedy date parsing in read_html #7851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/source/v0.15.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ API changes

See the the caveats in the documentation: http://pandas.pydata.org/pandas-docs/stable/indexing.html#indexing-view-versus-copy

- The ``infer_types`` argument to :func:`~pandas.io.html.read_html` now has no
effect (:issue:`7762`, :issue:`7032`).


.. _whatsnew_0150.cat:

Expand Down Expand Up @@ -320,6 +323,8 @@ Bug Fixes



- Bug in ``read_html`` where the ``infer_types`` argument forced coercion of
date-likes incorrectly (:issue:`7762`, :issue:`7032`).



Expand Down
14 changes: 3 additions & 11 deletions pandas/io/html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,11 +607,6 @@ def _data_to_frame(data, header, index_col, skiprows, infer_types,
parse_dates=parse_dates, tupleize_cols=tupleize_cols,
thousands=thousands)
df = tp.read()

if infer_types: # TODO: rm this code so infer_types has no effect in 0.14
df = df.convert_objects(convert_dates='coerce')
else:
df = df.applymap(text_type)
return df


Expand Down Expand Up @@ -757,9 +752,8 @@ def read_html(io, match='.+', flavor=None, header=None, index_col=None,
that sequence. Note that a single element sequence means 'skip the nth
row' whereas an integer means 'skip n rows'.

infer_types : bool, optional
This option is deprecated in 0.13, an will have no effect in 0.14. It
defaults to ``True``.
infer_types : None, optional
This has no effect since 0.15.0. It is here for backwards compatibility.

attrs : dict or None, optional
This is a dictionary of attributes that you can pass to use to identify
Expand Down Expand Up @@ -838,9 +832,7 @@ def read_html(io, match='.+', flavor=None, header=None, index_col=None,
pandas.io.parsers.read_csv
"""
if infer_types is not None:
warnings.warn("infer_types will have no effect in 0.14", FutureWarning)
else:
infer_types = True # TODO: remove effect of this in 0.14
warnings.warn("infer_types has no effect since 0.15", FutureWarning)

# Type check here. We don't want to parse only to fail because of an
# invalid value of an integer skiprows.
Expand Down
Loading