Skip to content

DOC: table keyword missing in the docstring for Series.plot() and DataFr... #7698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2014

Conversation

mortada
Copy link
Contributor

@mortada mortada commented Jul 8, 2014

...ame.plot()

@mortada
Copy link
Contributor Author

mortada commented Jul 8, 2014

HTML doc for this can be found here: http://pandas.pydata.org/pandas-docs/stable/visualization.html#plotting-tables

table : boolean, Series or DataFrame, default False
If True, draw a table using the data in the DataFrame
If a Series or DataFrame is passed, use passed data to draw a table
Data will be transposed to meet matplotlib’s default layout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put full stops . after each sentence? (in this text it looks good, but when it is rendered ti html, the different lines become continuous text)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, PR updated

@jorisvandenbossche
Copy link
Member

@sinhrks this is correct?

table : boolean, Series or DataFrame, default False
If True, draw a table using the data in the DataFrame.
If a Series or DataFrame is passed, use passed data to draw a table.
Data will be transposed to meet matplotlib’s default layout.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This transpose is for making plotting internal data to mpl table layout. Thus, transposed only in boolean., not in another DataFrame and Series is passed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch thanks! Fixed and PR updated.

@sinhrks
Copy link
Member

sinhrks commented Jul 8, 2014

Thans for this. Only one comment.

@jreback jreback added the Docs label Jul 8, 2014
@jreback
Copy link
Contributor

jreback commented Jul 8, 2014

@jorisvandenbossche looks ok to me

@jreback jreback added this to the 0.14.1 milestone Jul 8, 2014
@jorisvandenbossche
Copy link
Member

@mortada Thanks a lot!

jorisvandenbossche added a commit that referenced this pull request Jul 9, 2014
DOC: table keyword missing in the docstring for Series.plot() and DataFr...
@jorisvandenbossche jorisvandenbossche merged commit 372008a into pandas-dev:master Jul 9, 2014
yarikoptic added a commit to neurodebian/pandas that referenced this pull request Jul 15, 2014
Version 0.14.1

* tag 'v0.14.1': (21 commits)
  RLS: v0.14.1 final
  DOC: clean up 0.14.1 whatsnew file
  CI: remove sql from 3.3 build entirely
  DOC: docstring for PeriodIndex
  SQL: suppress warning for BIGINT with sqlite and sqlalchemy<0.8.2 (GH7433)
  TST/REG/BUG: Make PeriodIndex work with Series objects
  DOC: fix problem with part of code example cut off
  TST: additional network error catching (test_html/test_spam_html)
  DOC: fix doc build warnings
  BUG: offset normalize option may not work in addition/subtraction
  DOC: add release thanks note
  DOC: fix non-ascii character (from pandas-dev#7698)
  DOC: table keyword missing in the docstring for Series.plot() and DataFrame.plot()
  TST/CLN: centralize numpy < 1.7 skips TST: skip on older numpy for (GH7694)
  BUG: Fix conditional for underlying price in io.data.options.
  TST:  fix dtypes in select_dtypes (GH7434) on windows
  PERF: better perf on min/max/resample when on indices not containing NaT for DatetimeIndex/PeriodIndex (GH7633)
  DOC: minor corrections in v0.14.1
  FIX: to_sql takes the boolean column as text column
  BUG: grouped hist raises error with single group
  ...
@mortada mortada deleted the df_table branch April 25, 2015 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants