BUG: DatetimeIndex.delete with tz raises ValueError #7608
Merged
+66
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1645,7 +1645,8 @@ def delete(self, loc): | |||
| freq = self.freq | |||
|
|
|||
| if self.tz is not None: | |||
| new_dates = tslib.date_normalize(new_dates, self.tz) | |||
| f = lambda x: tslib.tz_convert_single(x, 'UTC', self.tz) | |||
| new_dates = np.vectorize(f)(new_dates) | |||
There was a problem hiding this comment.
any better way to do this?
this is pretty slow
There was a problem hiding this comment.
Using tslib.tz_convert is better to handle array. But it looks having a bug in DST I don't fully understand. I'll try to dig in.
|
@sinhrks update? |
|
@jreback updated to use tz_convert_with_transition. |
jreback
added a commit
that referenced
this pull request
Jul 3, 2014
BUG: DatetimeIndex.delete with tz raises ValueError
|
gr8 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found and fixed
DatetimeIndex.delete(#7302) results inValueErrorwhen it hastzandfreqis less than daily..insert(#7299) andtakedon't have problems, but changed test case to use hourly frequencies to detect this kind of problem.