-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
API: DatetimeIndex and PeriodIndex have same representation #7602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
doesn't need a tz |
OK. Removed tz repr from |
return summary | ||
|
||
def __str__(self): | ||
if compat.PY3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are not needed - this is a mixin but all object inherit from the PandasObject which already have these defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, not noticed. Removed.
can this integrate some of the DatetimeIndex formatting stuff? and out in Base (while leaving the output the same) in theory could do similarly with Series though might be much trickier |
needs rebase |
Rebased and examples are attached. |
API: DatetimeIndex and PeriodIndex have same representation
thanks! |
Closes #7601. Made
PeriodIndex
to have dummy timezone representation to be consistent withDatetimeIndex
, but this should be ommited?Output after the fix