Skip to content

BUG: DatetimeIndex.asobject raises ValueError when contains NaT #7544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2014

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Jun 21, 2014

Closes #7539.

Also, this fixed #7112 case 3 and case 4 to preserve tz. I've modified the tests for it.

Related to #6469.

@jreback
Copy link
Contributor

jreback commented Jun 21, 2014

pls do a perf check make sure nothing really changed

@jreback jreback added this to the 0.14.1 milestone Jun 22, 2014
@sinhrks
Copy link
Member Author

sinhrks commented Jun 23, 2014

Result of vbench attached.

  • 1st time
-------------------------------------------------------------------------------
Test name                                    | head[ms] | base[ms] |  ratio   |
-------------------------------------------------------------------------------
groupby_frame_cython_many_columns            |  13.8263 |  12.6497 |   1.0930 |
packers_write_json_date_index                | 249.6490 | 225.3887 |   1.1076 |
packers_write_pack                           |  85.4166 |  75.2767 |   1.1347 |
datetimeindex_normalize                      | 195.3310 | 162.7570 |   1.2001 |
  • 2nd time
write_store_table_mixed                      |  74.6583 |  64.0423 |   1.1658 |
frame_isnull                                 |   2.7107 |   2.2360 |   1.2123 |
reindex_daterange_backfill                   |   2.4064 |   1.9484 |   1.2351 |
dtype_infer_int32                            |   3.3810 |   2.7177 |   1.2441 |
stat_ops_frame_mean_float_axis_0             |   2.3917 |   1.8989 |   1.2595 |
series_drop_duplicates_string                |   1.1253 |   0.8860 |   1.2702 |

@jreback
Copy link
Contributor

jreback commented Jun 23, 2014

this is ok...ping when green

@sinhrks
Copy link
Member Author

sinhrks commented Jun 24, 2014

@jreback now green.

jreback added a commit that referenced this pull request Jun 24, 2014
BUG: DatetimeIndex.asobject raises ValueError when contains NaT
@jreback jreback merged commit 2bd4517 into pandas-dev:master Jun 24, 2014
@sinhrks sinhrks deleted the dtmixin branch June 26, 2014 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Compat pandas objects compatability with Numpy or Python functions Datetime Datetime data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: DatetimeIndex.asobject raises ValueError when contains NaT
2 participants