nanops pep8 fixes #7461
Merged
nanops pep8 fixes #7461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if dtype.kind == 'i' and not issubclass( | ||
| dtype.type, (np.bool, np.datetime64, np.timedelta64)): | ||
| if dtype.kind == 'i' and not issubclass(dtype.type, (np.bool, | ||
| np.datetime64, |
There was a problem hiding this comment.
u can use com.is_integer_dtype here (if u can replace anything else with the com.is_ functions would be gr8)
There was a problem hiding this comment.
I can do a separate code cleanup in another pull request, but for triaging purposes I think it would be best to restrict this pull request to only stylistic (non-functional) changes. Ideally changes like you suggested should not have an affect, but they still alter the code paths to some degree so I think they should be kept separate.
|
@toddrjen ok...if you would do a pr for those items discussed above would be great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minor pep8 fixes for
nanops. This bringsnanopsinto pep8 compliance.