BUG/CLN: LinePlot uses incorrect xlim when secondary_y=True #7459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cpcloud ? |
|
@sinhrks ? |
| @@ -2932,12 +2908,6 @@ def _subplots(nrows=1, ncols=1, naxes=None, sharex=False, sharey=False, squeeze= | |||
|
|
|||
| ax : Matplotlib axis object, optional | |||
|
|
|||
| secondary_y : boolean or sequence of ints, default False | |||
| If True then y-axis will be on the right | |||
|
|
|||
|
cc @rosnfeld ok with this? |
|
Not sure how deep a review I can do as I am just about to head out abroad again (more or less offline until August), but this does seem to behave properly in various ad-hoc tests, and seems to clean up a few things that surprised me when I first started looking at plotting code. A somewhat larger/more dramatic change than I would have expected, but glad to see that larger changes are possible/being done to the somewhat thorny (IMO) plotting code. |
jreback
added a commit
that referenced
this pull request
Jul 7, 2014
BUG/CLN: LinePlot uses incorrect xlim when secondary_y=True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xlimis not set properly whensecondary_y=True. This is different issue from #7322.Also, refactored
secondary_yto be handled only byMPLPlot, because it will be required in future fix to pass multiple axes todf.plot, like #7069 (I'm willing to work soon..).