TST/CLN: centralize module check funcs #7451
Conversation
|
looks reasonable |
|
can I update the wiki to mention in the testing section that this is how to skip tests if the import isn't available thanks |
| import scipy.interpolate | ||
| except ImportError: | ||
| import nose | ||
| raise nose.SkipTest('scipy.interpolate missing') |
There was a problem hiding this comment.
I don't think it ever happens one of the two is available and the other not? (all scipy version we support have both submodules?) So maybe just checking for scipy? (because now you will get scipy.stats not installed for tests that need scipy.interpolate
There was a problem hiding this comment.
not true
scipy 0.10 or 0.11 breaks on scipy.stats (I have it on windows)
There was a problem hiding this comment.
ah, didn't know (never had that problem on windows). But still, shouldn't it be in two seperate functions then? The tests that use interpolate should not be skipped due to stats?
There was a problem hiding this comment.
Or leave it local func because scipy.interpolate requirement is only checked in test_generic.py.
TST/CLN: centralize module check funcs
util.testing