-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: GH3850, add .isin to 10min.rst #7239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -287,6 +287,16 @@ A ``where`` operation for getting. | |||
|
|||
df[df > 0] | |||
|
|||
An ``isin`` operation for filtering: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add something like using the :func:
~Series.isin method
(to have the link to the isin
docstring page)?
@clham Thanks for your contribution! I just added some comments. |
Fixed all but |
You may need to put pandas in front of Series |
@cpcloud, I tried that along with a few other syntax. Interestingly, when I compile the docs, many of the |
@clham Do you get any warning or error messages? Because normally this should just work, and also strange that api.rst is not building correctly (what is exactly not working? is it only the link that does not work but it renders well for the rest?) |
Pages render properly, however it looks like the actual docstrings are not being produced. In the
Several other sections have similar problems. The sourcedoc pages do compile, but the body of the page is blank other than the header. The following is the first error I get when I run
I'm not sure if this is related (or useful), but in ipython, |
@clham It is possibly another issue with out python 3 compat for building the docs. See my comment here: #5530 (comment) (first point, seems the same error message). For me this appeared only after rebuilding the docs, not with a clean build. Can you try a clean build (just do first |
@jorisvandenbossche That worked. Also, that link to #5530 was crazy informative. |
OK, @clham, to get this merged, can you first squash the commits? (so you have only one commit for this addition) You can normally do this with Another tip: never merge master in your branch, always rebase ( |
BTW, if you find other fixes for the issues with python 3 you encounter (and mentioned in #5530), we are glad to improve this (but I myself am not working with python 3 yet for the docs) |
Well... That was an adventure in git. I think I'm good at this point -- please let me know otherwise. |
Yep, looking good now! Thanks again, and your first PR can be merged :-) |
DOC: GH3850, add .isin to 10min.rst
closes #3850.
Updates 10min.rst to demonstrate isin