Skip to content

CLN: Deprecation of assert_ #7172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2014
Merged

CLN: Deprecation of assert_ #7172

merged 2 commits into from
May 19, 2014

Conversation

bwignall
Copy link
Contributor

#7131: Run s/self.assert_(/self.assertTrue( on remaining instances I can find. These were the multi-line expressions, and I tried to retain the formatting of the expressions

bwignall added 2 commits May 19, 2014 08:41
#7131: Run s/self.assert_(/self.assertTrue( on remaining instances I can find. These were the multi-line expressions, and I tried to retain the formatting of the expressions
Fix formatting of one multi-line assertion, from assert_ --> assertTrue cleanup
@jreback
Copy link
Contributor

jreback commented May 19, 2014

here's an example of running with PANDAS_TESTING_MODE='deprecate' on 3.4: https://travis-ci.org/jreback/pandas/jobs/25480011

@jreback jreback added this to the 0.14.0 milestone May 19, 2014
@bwignall
Copy link
Contributor Author

Thanks, @jreback, I will look through that in more detail later today.

jreback added a commit that referenced this pull request May 19, 2014
@jreback jreback merged commit 034c994 into pandas-dev:master May 19, 2014
@bwignall bwignall deleted the issue7131_assert_ branch May 19, 2014 13:34
@jreback jreback mentioned this pull request May 22, 2014
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants