BUG: allow dup indexing with Float64Index #7149
Merged
+92
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -401,6 +401,35 @@ cdef class Float64Engine(IndexEngine): | |||
| cdef _get_index_values(self): | |||
| return algos.ensure_float64(self.vgetter()) | |||
|
|
|||
| cdef _maybe_get_bool_indexer(self, object val): | |||
There was a problem hiding this comment.
so this is only hit when the Float64Index is non-monotonic and non-unique?
There was a problem hiding this comment.
and only if you try to slice it.... it works for single element access
There was a problem hiding this comment.
actually nevermind ... it only raises if you try to pass a slice in
cpcloud
changed the title
|
@jreback should this be in 0.14.0? or not serious enough? |
|
let's hold off on this |
|
looks good....add a whatsnew (0.14.1) note and looks good |
cpcloud
added a commit
that referenced
this pull request
Jun 1, 2014
BUG: allow dup indexing with Float64Index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7143