SQL: resolve legacy mode + deprecate mysql flavor (GH6900) #7077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed warning for not using sqlalchemy (as sqlite DBAPI connection is fully supported, no warning needed) - added deprecation warning for 'mysql' flavor - removed necessity of providing flavor kwarg (no warning if not provided, assumed to be sqlite3) - removed `flavor` kwarg from execute and read_sql_query (because a) are not database specific functions + b) would only be needed for mysql, but this will is deprecated so no need to introduce it) - updated the tests to reflect this - updated docs and docstrings to reflect that sqlite3 is the only but fully supported DBAPI connection (no 'legacy')
|
@hayd @danielballan @jreback This can use some carefull review I think. |
|
Looks thorough and correct. I can't find an issue. |
|
OK, then I am going to merge this. Further comments are always welcome after-merge! (but it's a bit difficult to futher work on the sql code with a lot of PRs open) |
jorisvandenbossche
added a commit
that referenced
this pull request
May 11, 2014
SQL: resolve legacy mode + deprecate mysql flavor (GH6900)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flavorkwarg from execute and read_sql_query (because a) are not database specific functions + b) would only be needed for mysql, but this will is deprecated so no need to introduce it)Closes #6900.