Skip to content

Added dropna to docstring for HDFStore.put() #7064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2014

Conversation

davidljung
Copy link
Contributor

HDFStore.put() method accepts dropna boolean parameter as it is passed
directly to the internal _write_to_group() method, but it was not
explicitly documented (as it is for append). Also settable via option.
Just added 2 lines to the put() method docstring to mention it explicitly - copied from append()

@jreback
Copy link
Contributor

jreback commented May 7, 2014

great.....can you squash to 1 commit: https://github.com/pydata/pandas/wiki/Using-Git
otherwise looks fine

@jreback
Copy link
Contributor

jreback commented May 7, 2014

you didn't need to close the other and open a new one

you can simply force push which overwrites the commits (this is what squashing then pushing with -f will do, FYI)

@jreback jreback added this to the 0.14.0 milestone May 7, 2014
@davidljung davidljung closed this May 7, 2014
@jreback
Copy link
Contributor

jreback commented May 7, 2014

@davidljung did you close this?

@davidljung
Copy link
Contributor Author

@jreback - yes - I didn't realize. I'll try to get it right when I have another moment. Obviously, fairly new to GitHub and my attempt to squash from your link doesn't appear to have worked. I'll figure it out. (Sorry for so much trouble for a 2-line change - but I'll know for next time)

@jreback
Copy link
Contributor

jreback commented May 8, 2014

hah!

git-fu is tricky at first.....that's why its nice to figure it out on a smallish change!

you can reopen one of these and just force push to it

@davidljung davidljung reopened this May 8, 2014
jreback added a commit that referenced this pull request May 8, 2014
Added dropna to docstring for HDFStore.put()
@jreback jreback merged commit ec3b979 into pandas-dev:master May 8, 2014
@jreback
Copy link
Contributor

jreback commented May 8, 2014

gr8 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO HDF5 read_hdf, HDFStore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants