Skip to content

BUG: DatetimeIndex cannot parse string ndarray with dayfirst #7038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2014

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented May 5, 2014

Closes #5917.

@jreback
Copy link
Contributor

jreback commented May 5, 2014

can you run a perf check and post the outliers (i dont' think its a problem), but just checking

@jreback jreback added this to the 0.14.0 milestone May 5, 2014
@jreback
Copy link
Contributor

jreback commented May 7, 2014

@sinhrks can you post a perf check?

@jreback
Copy link
Contributor

jreback commented May 9, 2014

@sinhrks need a perf check on this

@sinhrks
Copy link
Member Author

sinhrks commented May 10, 2014

@jreback Sorry to delay. Rebased, and following is vbench results. Looks OK as there is no tests get slower constantly.

# 1st run
-------------------------------------------------------------------------------
Test name                                    | head[ms] | base[ms] |  ratio   |
-------------------------------------------------------------------------------
groupby_pivot_table                          |  43.2317 |  36.2120 |   1.1939 |
frame_reindex_axis1                          | 372.5393 | 306.3263 |   1.2162 |
groupby_transform                            | 405.6187 | 328.8047 |   1.2336 |
groupby_multi_different_numpy_functions      |  30.6609 |  24.5076 |   1.2511 |
groupby_indices                              |  19.0316 |  14.9120 |   1.2763 |
groupby_multi_series_op                      |  33.6157 |  26.0634 |   1.2898 |
groupby_multi_count                          |  18.2153 |  14.0044 |   1.3007 |
groupby_multi_different_functions            |  30.1137 |  22.8820 |   1.3160 |
groupby_sum_booleans                         |   2.6333 |   1.9503 |   1.3502 |
dataframe_reindex                            |   1.1314 |   0.8047 |   1.4060 |
groupby_last                                 |   9.5390 |   6.7446 |   1.4143 |
-------------------------------------------------------------------------------

# 2nd run
-------------------------------------------------------------------------------
Test name                                    | head[ms] | base[ms] |  ratio   |
-------------------------------------------------------------------------------
frame_drop_dup_inplace                       |   6.6934 |   5.7159 |   1.1710 |
reindex_fillna_backfill                      |   1.0877 |   0.8977 |   1.2116 |
frame_constructor_ndarray                    |   0.2096 |   0.1643 |   1.2756 |
ctor_index_array_string                      |   0.0536 |   0.0420 |   1.2784 |
frame_get_numeric_data                       |   0.3580 |   0.2743 |   1.3050 |
series_constructor_ndarray                   |   0.0536 |   0.0386 |   1.3889 |
index_from_series_ctor                       |   0.0663 |   0.0473 |   1.4017 |
-------------------------------------------------------------------------------

@cpcloud
Copy link
Member

cpcloud commented May 10, 2014

Are those against latest master?

@sinhrks
Copy link
Member Author

sinhrks commented May 10, 2014

Based on latest master on May 9th. Anything unexpected?

Target [bdb2f8f] : modified
Base   [16a8902] : Merge pull request #7081 from TomAugspurger/fwf-slice

BUG: read_fwf colspec should treat None like slice

@sinhrks
Copy link
Member Author

sinhrks commented May 10, 2014

Rebased to latest and run perf again.

-------------------------------------------------------------------------------
Test name                                    | head[ms] | base[ms] |  ratio   |
-------------------------------------------------------------------------------
reindex_fillna_backfill                      |   1.0796 |   0.9297 |   1.1613 |
timeseries_1min_5min_mean                    |   1.3570 |   1.0761 |   1.2611 |
frame_get_numeric_data                       |   0.3453 |   0.2646 |   1.3048 |
-------------------------------------------------------------------------------

Target [ee1e70b] : BUG: DatetimeIndex cannot parse string ndarray with dayfirst
Base   [ecaa39c] : Merge pull request #7087 from jreback/series_cache

jreback added a commit that referenced this pull request May 10, 2014
BUG: DatetimeIndex cannot parse string ndarray with dayfirst
@jreback jreback merged commit 953ba54 into pandas-dev:master May 10, 2014
@jreback
Copy link
Contributor

jreback commented May 10, 2014

thanks!

@sinhrks sinhrks deleted the dayfirst branch May 10, 2014 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Datetime Datetime data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dayfirst non working when constructing a pd.DatetimeIndex with an array
3 participants