-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: fix reading multi-index data in python parser #7029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1383,7 +1383,7 @@ def __init__(self, f, **kwds): | |
# multiple date column thing turning into a real spaghetti factory | ||
if not self._has_complex_date_col: | ||
(index_names, | ||
self.orig_names, columns_) = self._get_index_name(self.columns) | ||
self.orig_names, self.columns) = self._get_index_name(self.columns) | ||
self._name_processed = True | ||
if self.index_names is None: | ||
self.index_names = index_names | ||
|
@@ -1811,8 +1811,9 @@ def _get_index_name(self, columns): | |
columns.insert(0, c) | ||
|
||
# Update list of original names to include all indices. | ||
self.num_original_columns = len(next_line) | ||
return line, columns, orig_names | ||
orig_names = list(columns) | ||
self.num_original_columns = len(columns) | ||
return line, orig_names, columns | ||
|
||
if implicit_first_cols > 0: | ||
# Case 1 | ||
|
@@ -1824,7 +1825,7 @@ def _get_index_name(self, columns): | |
|
||
else: | ||
# Case 2 | ||
(index_name, columns, | ||
(index_name, columns_, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This duplicates the previous behavior of ignoring the columns returned by _clean_index_names, except now we are not ignoring the columns returned by _get_index_name which may contain index columns (see "case 0") |
||
self.index_col) = _clean_index_names(columns, self.index_col) | ||
|
||
return index_name, orig_names, columns | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't ignore columns here, we will lose the columns added from the row specifying the index...