BUG: Pass args and kwargs to empty #6953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6952
I wasn't sure what the best way to test this was. I went with calling
_apply_empty_result
directly and checking for a SystemExit to get around the try: except Exception block in_apply_empty_result
.I still don't think I've 100% ensured that
_apply_empty_result
will always be called with _args and *_kwargs (if there are any), but if they are passed things will be handled correctly.