-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
SQL: add multi-index support to legacy mode #6883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL: add multi-index support to legacy mode #6883
Conversation
and at once also index_label kwarg support
That was quick. This seems like the best outcome from an assortment of confusing compromises, any of which could mean trouble for legacy code. Looks good to me. I will proceed with #6796 once this is merged. |
Actually, we could also set (at this moment, |
looks ok |
SQL: add multi-index support to legacy mode
Ahum, I was actually completely wrong here... |
Bummer. But I still think this is the lesser evil. Dropping the index was always a weird behavior, an indication that the SQL capability wasn't mature and should be used cautiously. |
Closes #6881.
@danielballan Added multi-index support to legacy mode, wasn't actually not that difficult (all tests seems to pass). And at once also
index_label
kwarg is supported in legacy mode.This just leaves the issue that this is actually an api change, so could possibly break code.