CLN: simplify series plotting #6876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1963,16 +1960,6 @@ def plot_frame(frame=None, x=None, y=None, subplots=False, sharex=True, | |||
| figsize=figsize, logx=logx, logy=logy, | |||
| sort_columns=sort_columns, secondary_y=secondary_y, | |||
| **kwds) | |||
| elif kind == 'hexbin': | |||
| C = kwds.pop('C', None) # remove from kwargs so we can set default | |||
There was a problem hiding this comment.
does anything need to be done to maintain this part?
|
looks fine and +1 for simplifying the code a little, going to leave it open for a bit for comments (if any) then merge |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified these 2 points:
LinePlot._make_ts_plotto have single flow.plot_frameandplot_series'skinddetection. (Also, setting hexbin default is not necessary because it is done inHexBinPlot.__init__)