-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Scatter plot now supports errorbar #6834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
can you rebase this on top of master again, then we can review |
Sure. Rebased. |
@TomAugspurger can you give a look see |
@sinhrks need a release note for this pls |
Rebased. I've thought release note is not requreid because error bar itself is new function of v0.14, and release note has following description. Should I prepare separate one?
|
oh just add this note number (or pr numbe) to that one |
OK, added PR number. |
Thanks @sinhrks. Could you rebase off master now that the Area plot is merged? There are a few conflicts in |
@TomAugspurger Sure, rebased to latest master. Plotting test has been passed in Travis, and looks fail in offset test. |
pls rebase 1 more time, master is fixed up |
Thanks, rebased. |
Thanks. @jreback a failure in |
@TomAugspurger yeh...thouse fail every once in a while on 3.4, not really sure why. if you would like to investigate give it a go! otherwise this PR is ok |
ENH: Scatter plot now supports errorbar
Excellent. Thanks @sinhrks |
This is enhancement for #5638. I sometimes want to plot scatter with errorbars, thus I've refactored to support it.
Also, this includes following fixes. I've also modified tests to check the number of errorbars actually drawn.
ValueError
.float
(MPL can accept it)unicode
(in Python 2.x)iterator