ENH: rename function now has errors keyword #6767
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same background as #6736.
Currently,
rename
error.drop
raisesValueError
in such a case.I think it is nice if
rename
also haserrors
keyword to:rename
only non-problematic labels (errors='ignore'
), or raise error whatever derived from the function (errors='raise'
).rename
only non-problematic labels (errors='ignore'
), or raise error if any of label is not included in the target axis (errors='raise'
).I feel the default should be
errors='raise'
in the future version based on the other functions behavior. This doesn't affect to the current behavior when a function is passed, but affects to when a dict is passed.In this version,
rename
raiseFutureWarning
for future precaution if it is called with non-existing label. And it is possible to forcerename
to raiseValueError
in such a case by specifyingerrors='raise'
.