Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjustments to the quick fix PR.
https://gist.github.com/dalejung/9731798#file-vb_suite-log
Note, that the speed up was really in sending a C order array to
np.take
. You'll notice that master is slow forframe_shift_c_order_
which are tests where theblock.values
is c_contiguous. Thus current master always transposes.The original example had it's speed up because it
np.roll
eddf.values
which is C ordered (fast) while the.blocks
were were (slow).