CLN: Fix many indentation errors found in #6643. #6646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,85 +1,87 @@ | |||
| # reasonably efficient | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
fyi, I don't think this script is used anywhere.....
There was a problem hiding this comment.
Well, that means I won't worry about removing list from sorted(list(...))..
|
@dsm054 can you rebase (and remove the sql stuff)...then can merge |
|
@dsm054 can you rebase this.... |
|
@dsm054 want to rebase this? |
|
Okay, this is the next one up. |
| c_dtype='O' | ||
| recons.columns = np.array(lmap(Timestamp,recons.columns), | ||
| df.index = np.array(lmap(_to_uni,df.index),dtype=r_dtype) | ||
| if r_dtype == 'dt': # unicode |
There was a problem hiding this comment.
I think so -- otherwise won't the else always be taken if r_dtype=='u'? And the parallel if c_dtype: version has elif:.
There was a problem hiding this comment.
If we want to fix that, I can make a separate one-line PR.
jreback
added a commit
that referenced
this pull request
Jun 17, 2014
CLN: Fix many indentation errors found in #6643.
|
ok make a one liner for that elif change pls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes should only affect whitespace.
closes #6643