ENH: Have inferred_freq set offset. Have freq always try to infer. #6637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm on the fence about this. Having a property with side effects doesn't quite sit right to me. But I think it kinda makes sense here. If it didn't set
freq
, then it really doesn't make sense forfreq
to exist. I'd just useinferred_freq
all of the time.Now calling
freq
always tries to infer the frequency. Why not? Seems sensible to me.inferred_freq
is kind of redundant now, but I left it anyway. I was never really sure of the rationale for its existence.