CLN: Change assert_([not] isinstance(a,b)) to specialized forms #6577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will work on the Travis problems. (These did not get picked up locally, as I am running with 2.7.) |
|
rebase on master |
|
I fetched latest master and rebased (also, changed one superclass, to use tm.TestCase instead of unittest.TestCase). The two errors I am still seeing on Travis are "ImportError: No module named pandas". |
|
Travis is being flaky today... |
|
@bwignall rebase on master and travis should be ok now.....setuptools had changed and caused the install to fail |
jreback
added a commit
that referenced
this pull request
Mar 9, 2014
CLN: Change assert_([not] isinstance(a,b)) to specialized forms
|
@bwignall thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on #6175. Changes instances of assert_([not] isinstance(a,b)) to specialized assert[Not]IsInstance(a, b).