API: default value for read_excel sheet #6576
Conversation
|
can u add a test to validate this? |
|
Sure, will do. On Sat, Mar 8, 2014 at 3:49 AM, jreback [email protected] wrote:
|
|
@jreback Added this within the |
| @@ -63,6 +63,7 @@ New features | |||
| API Changes | |||
| ~~~~~~~~~~~ | |||
|
|
|||
| - ``read_excel`` uses 0 as the default sheet (:issue:`6573`) | |||
There was a problem hiding this comment.
can you add same line to v0.14.0.txt (in API section) as well
There was a problem hiding this comment.
also pls review io.rst / excel section : add that the default is to read the 0 th sheet in the example(s)
|
@jreback Docs revised. |
| ``sheet_name``. | ||
|
|
||
| - Pass a string to refer to the name of a particular sheet in the workbook. | ||
| - Pass an integer to refer to the index of a sheet. Indices follow Python |
There was a problem hiding this comment.
can you remove the leading spaces here
There was a problem hiding this comment.
I changed this to bullet point. Looks like the other bullet point sections use leading spaces.
|
all for clarity in the docs....but have to squeeze lots of things into a limited number of examples. If you can make it more clear, by all means (but at the same time try to show as much as possible) you can squash down to 1 commit right before we merge |
|
@jreback Ok, I changed those examples back to how they were. |
|
ok...pls squash.... you can look at the built docs (now and a few minutes after the merged) http://pandas-docs.github.io/pandas-docs-travis/ if you want to do a follow-up PR to fix/clarify docs...ok by me the excel sectino COULD use some TLC! |
|
That's good to know about the built docs. Could we put that link in this page - http://pandas.pydata.org/developers.html#contributing-to-the-documentation I'll squash when I get home tonight. Should I be using |
|
yeh....theirs been some work on add all of this info to the main docs, see here: http://pandas.pydata.org/pandas-docs/stable/contributing.html#contributing-to-the-documentation interactive rebase |
|
@jreback how does this rebase look? |
|
looks good! thanks...excellent PRing! do some more |
|
Glad to hear! I've got a much better handle on how to PR. Thanks @jreback for walking me through it. |
closes #6573
Implements a default sheetname of 0 for
read_excel#6573.Before:
read_excel(io, sheetname, **kwds)After:
read_excel(io, sheetname=0, **kwds)