-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
API change in groupby head and tail #6533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…age, fixes column selection
Note: definitely need to change some documentation here if we were to do this, but thought should put change out there. / discuss |
@jreback is a partial close 5755 (I'll make a checklist on that, some of it's also up for discussion, should clean it up in one-hit IMO - this coming release). Ok, cool, will trawl through the docs to see what needs changing and add twice in release. |
Yeah this looks good. I'm looking forward to more consistency in groupby :) |
Updated... Something has broken the build (first commit passed travis and second only changes docs)! |
hmm..travis seems flaky right now....wait before merging this...let's see if can fix travis |
looks like whl are not being transported properly....(though I just accessed the server ok)....maybe a network issue from travis? |
shouldn't this level be named? (e.g. its the original index of the frame) maybe make a |
@hayd I realize that this is a case where |
@jreback haha, but you won't need to with this PR :) Ah, the unnamed level is from the original index (which had no name), no? Is pretty easy to write with cumcount:
(s390x ?!!) |
I thought he said mainframe. that's something the sparc guys can't even get numpy to run on, yet they want pandas to run ...meh |
@jreback you want me to rebase/amending? I want to do the nth stuff on top of this so would be good to merge. (I tried amending before but it failed) |
go ahead.....you can prob just merge this... (not sure why travis is acting up stilll) |
API change in groupby head and tail
we'll see... |
yeah, build still failing. |
BUG/API groupby head and tail act like filter, since they dont aggregage fixes column selection
Breaking API change to groupby head and tail, these were never aggregated output, so should not have the group labels as the index, it should always filter. (It was a legacy from when this was
g.apply(lambda x: x.head(n))
.)Also fixes the column selection for head and tail
part of #5755
related #6524
part of #5264.
cc @jreback @TomAugspurger