remove semicolon from CREATE TABLE legacy template #6510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not necessary and causes some DB engines to choke (e.g., Impala)
|
is this covered by new sql stuff? |
|
In principle we don't want to add support for more databases to the legacy code (that was the purpose of the new sqlalchemy based functions), but for such a small change this is OK for me. |
|
ok...prob untested right? go ahed and merge |
jorisvandenbossche
added a commit
that referenced
this pull request
Mar 11, 2014
remove semicolon from CREATE TABLE legacy template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not necessary and causes some DB engines to choke (e.g., Impala)