Skip to content

CLN: remove dead code in pandas.computation #6448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2014
Merged

CLN: remove dead code in pandas.computation #6448

merged 1 commit into from
Feb 23, 2014
+122 −217

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Feb 23, 2014

closes #5041

@cpcloud cpcloud self-assigned this Feb 23, 2014
@cpcloud
Copy link
Member Author

cpcloud commented Feb 23, 2014

Coverage:

Name                                 Stmts   Miss  Cover   Missing
------------------------------------------------------------------
pandas.computation                       0      0   100%
pandas.computation.align                96      0   100%
pandas.computation.api                   2      0   100%
pandas.computation.common               14      0   100%
pandas.computation.engines              63      6    90%   94, 122-126
pandas.computation.eval                 62      4    94%   39-40, 46, 90
pandas.computation.expr                330      4    99%   512-514, 538-540
pandas.computation.expressions         101      9    91%   106-107, 140-145, 197
pandas.computation.ops                 231      0   100%
pandas.computation.pytables            350      5    99%   37, 122, 165, 202, 233
pandas.computation.scope               103      8    92%   34-36, 72-74, 135-137
pandas.computation.tests                 0      0   100%
pandas.computation.tests.test_eval    1030      4    99%   50-51, 56, 166
------------------------------------------------------------------
TOTAL                                 2382     40    98%
----------------------------------------------------------------------
Ran 1099 tests in 88.447s

OK (SKIP=26)

@cpcloud
Copy link
Member Author

cpcloud commented Feb 23, 2014

Most uncovered there are Py3 things

@cpcloud
Copy link
Member Author

cpcloud commented Feb 23, 2014

@jreback You ok with this?

@cpcloud
Copy link
Member Author

cpcloud commented Feb 23, 2014

Obvs need 2 squash

@cpcloud
Copy link
Member Author

cpcloud commented Feb 23, 2014

Alright gonna squash it.

@jreback
Copy link
Contributor

jreback commented Feb 23, 2014

looks fine

cpcloud added a commit that referenced this pull request Feb 23, 2014
@cpcloud
Merge pull request #6448 from cpcloud/eval-coverage
e2f0b56 
CLN: remove dead code in pandas.computation
@cpcloud cpcloud merged commit e2f0b56 into pandas-dev:master Feb 23, 2014
@cpcloud cpcloud deleted the eval-coverage branch February 23, 2014 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cpcloud cpcloud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TST: Unused codepaths in computation/tests/test_eval
2 participants
@cpcloud @jreback