API: validate conversions of datetimeindex with tz, and fixup to_series() to handle (GH6032) #6398
+82
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| values = self.to_embed(keep_tz) | ||
| return pd.Series(values, index=self, name=self.name) | ||
|
|
||
| def to_embed(self, keep_tz=False): |
There was a problem hiding this comment.
Make this an internal function?
There was a problem hiding this comment.
you mean like _to_embed? I would except for asobject is already 'public'
There was a problem hiding this comment.
yes, that's what I meant. What would be the use that this is visible to users (I mean: appear in the api docs of index)?
…es() to handle (GH6032)
jreback
added a commit
that referenced
this pull request
Feb 19, 2014
API: validate conversions of datetimeindex with tz, and fixup to_series() to handle (GH6032)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6032