Skip to content

PERF: fix performance for series slices (even more) #6372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2014

Conversation

immerrr
Copy link
Contributor

@immerrr immerrr commented Feb 16, 2014

This is a continuation of #6341 and is related to #6370. The latter unfortunately concerns public API and may be not easy to fix gracefully.

So, regardless of the decision to be made in other ticket, this patch will optimize series slicing right away and remove some redundant code (no need to override __getslice__ because Series doesn't inherit ndarray anymore).

@immerrr
Copy link
Contributor Author

immerrr commented Feb 16, 2014

Here's the relevant part of vbench output:

Invoked with :
--ncalls: 3
--repeats: 3


-------------------------------------------------------------------------------
Test name                                    | head[ms] | base[ms] |  ratio   |
-------------------------------------------------------------------------------
series_getitem_pos_slice                     |   0.0510 |   4.7594 |   0.0107 |
frame_drop_dup_inplace                       |   2.4463 |   3.0230 |   0.8092 |
frame_reindex_columns                        |   0.3046 |   0.3696 |   0.8241 |
frame_mult_st                                |   3.8100 |   4.3863 |   0.8686 |
frame_mult_no_ne                             |   3.6847 |   4.2224 |   0.8727 |
<snip>

@jreback
Copy link
Contributor

jreback commented Feb 16, 2014

looks gr8! pls rebase on master and can get this in

@jreback jreback added this to the 0.14.0 milestone Feb 16, 2014
@immerrr
Copy link
Contributor Author

immerrr commented Feb 16, 2014

Done.

jreback added a commit that referenced this pull request Feb 16, 2014
PERF: fix performance for series slices (even more)
@jreback jreback merged commit af8732a into pandas-dev:master Feb 16, 2014
@jreback
Copy link
Contributor

jreback commented Feb 16, 2014

thank you!

@immerrr immerrr deleted the fix-perf-for-series-slices branch February 16, 2014 19:25
@immerrr immerrr restored the fix-perf-for-series-slices branch March 3, 2014 17:14
@immerrr immerrr deleted the fix-perf-for-series-slices branch March 3, 2014 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants