CLN: Convert last of assert_(x == y) to assertEqual #6308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work on #6175. Fixes last of vanilla assert_(x == y) conversions in pandas/tests and pandas/*/tests. Tests still pass locally.
|
The following returns seven results (when run from pandas), but none are in the assert_(x == y) category. grep -nH --recursive -e 'assert_(.*==' . | grep -v 'all()' | grep -v 'any()' I will handle the easy '!=' cases and then move to refactoring some of the other ideas discussed in #6175. |
Work on #6175. Converts instances in pandas/tests and pandas/*/tests. Tests still pass locally.
jreback
added a commit
that referenced
this pull request
Feb 12, 2014
CLN: Convert last of assert_(x == y) to assertEqual
|
In your next PR can you make an entry in release notes (improvements section), referencing these previous PR's to say that the testing statement were updated (just so their is a record of what changed) |
|
@jreback, thank you, I did this in the PR I submitted a moment ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on #6175. Fixes last of vanilla assert_(x == y) conversions in pandas/tests and pandas/*/tests. Tests still pass locally.