DOC: clarified to_excel and read_excel (GH6260) #6302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| .. code-block:: python | ||
|
|
||
| df.to_excel('path_to_file.xlsx', index_label='label', merge_cells=False) |
There was a problem hiding this comment.
you need an indentation here
|
Thanks for the contribution! I just added some small comments. There also seems something wrong with your history of commits (undo and redo again). You can clean this up by rebasing interactively (https://github.com/pydata/pandas/wiki/Using-Git#wiki-fetch-and-then-rebase-interactively-to-squash-reword-fix-otherwise-change-some-commits) and then squash the 5 commits in one. |
as discussed in issue GH6260 . io.rst: added a paragraph explaining the difference in behaviour from 0.12 . excel.py: added docstring for has_index_names thanks to jmcnamara and jorisvandenbossche
|
@jorisvandenbossche thanks for the education. Please let me know if everything is correct now. |
|
That looks very good now! Thanks again |
jorisvandenbossche
added a commit
that referenced
this pull request
Feb 9, 2014
DOC: clarified to_excel and read_excel (GH6260)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in issue #6260
thanks to jmcnamara
ps: sorry about the pollution with multiple commits, I'm still learning how to rebase/squash