BLD: setup.py version strings. handle shallow clones and installing from sdist #6217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis exposed a corner case in the handling of version strings since the
git-describe
shakeup.Previously (0.10.1), version strings were of the form:
Now that we use git-describe, here's the case breakdown:
the * cases were hard to see coming (I didn't) and so the current logic does not handle
them gracefully, and weird version strings result.
Behavior summary following this PR:
Slightly dangerous to merge shortly before a release, but it would be worse
to keep this brokenness for months until 0.14 IMO.