BUG/TST raise a more detailed error when GH6169 occurs, added a test #6200
+37
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise a detailed error when a `columns` argument is passed through 'where' to select a multiIndexed Dataframe from an HDF store. Wrote a test showcasing the bug modified: pandas/io/pytables.py modified: pandas/io/tests/test_pytables.py making it work
| name='A') | ||
| with ensure_clean_store(self.path) as store: | ||
| store.put('s', s) | ||
| tm.assert_frame_equal(store.select('s', where="columns=['A']"),s, |
There was a problem hiding this comment.
I'm not sure this should work like that... It is kind of absurd to pass a columns argument to select data from a Series object, so maybe that should rise an error (actually even if columns is passed as an argument to select directly an error should occur).
|
you're welcome! |
|
and as always...pls report any further issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise a detailed error when a
columnsargument is passed through 'where' toselect a multiIndexed Dataframe from an HDF store. Wrote a test
showcasing the bug