BUG: allow single element bool queries #6163
Conversation
| # only scalars or indexes | ||
| if all(isinstance(term.value, pd.Index) or term.isscalar for term in | ||
| terms): | ||
| return np.result_type(*term_values), None | ||
|
|
||
| # single element ndarrays | ||
| all_has_size = all(hasattr(term.value, 'size') for term in terms) |
There was a problem hiding this comment.
out of curiosity why was this squeezing in here? (IIRC you wanted to support scalar booleans, e.g. True/False)?
There was a problem hiding this comment.
IIRC it was because I wanted to support numpy scalars...turns out not necessary to make that check to do that
There was a problem hiding this comment.
gr8...go ahead and merge on green then
There was a problem hiding this comment.
I'm trying out some pathological cases to make sure that I didn't break something we didn't write tests for (if that's even a thing) :)
|
I see a tiny yellow dot 😢 what happened to the big yellow/red/green banners? I liked those. |
|
where's the dot? |
|
It was next to the commit hash, now it's gone .... |
ghost
assigned
|
Not totally sure how it's supposed to work. |
|
I see them now...I think they just take time to show up |
BUG: allow single element bool queries
|
Ok I'm just watching travis |
closes #6148