BUG: Fix assert_frame_equal dtype handling when check_dtype=False (#61473) #61525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iabhi4
force-pushed
the
bugfix-assert_frame_equal-check_dtype-61473
branch
3 times, most recently
from
ad74d18 to
e738953
Compare
mroeschke
reviewed
Jun 2, 2025
iabhi4
force-pushed
the
bugfix-assert_frame_equal-check_dtype-61473
branch
from
e738953 to
5e422e4
Compare
iabhi4
force-pushed
the
bugfix-assert_frame_equal-check_dtype-61473
branch
from
5e422e4 to
fcac82c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in
assert_frame_equalwhereDataFrameswith logically equal values but different dtypes (nullable vs non-nullable) would raise errors even with check_dtype=False. Now, whencheck_dtype=False, dtype mismatches won’t cause failures.closes BUG: assert_frame_equal(check_dtype=False) fails when comparing two DFs containing pd.NA that only differ in dtype (object vs Int32) #61473
Tests added and passing
Pre-commit checks passing
Added entry to v3.0.0.rst