Skip to content

BUILD: Bump Cython to 3.1 #61519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

BUILD: Bump Cython to 3.1 #61519

wants to merge 3 commits into from
+13 −12

Conversation

rhshadrach
Copy link
Member

ASVs: #60972 (comment)

@rhshadrach rhshadrach added Build Library building on various platforms Dependencies Required and optional dependencies labels May 30, 2025
@rhshadrach rhshadrach added this to the 2.3 milestone May 30, 2025
rhshadrach
rhshadrach commented May 30, 2025
View reviewed changes
asv_bench/asv.conf.json
@@ -42,7 +42,7 @@
// followed by the pip installed packages).
"matrix": {
"pip+build": [],
"Cython": ["3.0"],
"Cython": [],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this was ever specified; we'll use our envornment.yaml for ASVs.

mroeschke
mroeschke reviewed May 30, 2025
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also bump cython in the ci/deps files?

I suppose after this PR we'll need to bump Cython in the conda forge recipe too

@rhshadrach
Copy link
Member Author

Could you also bump cython in the ci/deps files?

Bumped. The pin there was cython>=0.29.33 (except freethreading which doesn't have any pin), but I do think having some upper bound is preferable.

From the 2 to 3 transition, I was cautious about accepting new versions and I think now overly so. What do you think about cython<4 instead?

@mroeschke
Copy link
Member

From the 2 to 3 transition, I was cautious about accepting new versions and I think now overly so. What do you think about cython<4 instead?

Yeah I would be OK with that (modulo pinning below alpha/rc release versions since Cython often to pre-releases before major version bumps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke left review comments

Assignees
No one assigned
Labels
Build Library building on various platforms Dependencies Required and optional dependencies
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

ENH: Support for Python 3.13.2 free-threading version
2 participants
@rhshadrach @mroeschke