BUG: Fixed issue with bar plots not stacking correctly when 'stacked' and 'subplots' are used together #61340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clarification if it matters)
mroeschke
reviewed
Apr 23, 2025
Comment on lines
+1935
to
+1941
| self.subplots: list[Any] | ||
| if self.subplots: | ||
| subplots_flag = 1 | ||
| else: | ||
| subplots_flag = 0 | ||
|
|
||
| if subplots_flag & self.stacked: |
There was a problem hiding this comment.
Suggested change
| self.subplots: list[Any] | |
| if self.subplots: | |
| subplots_flag = 1 | |
| else: | |
| subplots_flag = 0 | |
| if subplots_flag & self.stacked: | |
| if self.subplots and self.stacked: |
mroeschke
reviewed
Apr 23, 2025
Comment on lines
+1942
to
+1951
| sub_range = range(len(self.subplots)) | ||
| ss_temp = { | ||
| x: self.subplots[x] for x in sub_range if len(self.subplots[x]) > 1 | ||
| } | ||
| for k, v in ss_temp.items(): | ||
| for x in v: | ||
| _stacked_subplots_ind.setdefault(int(x), k) | ||
|
|
||
| _stacked_subplots_offsets.append([0, 0]) | ||
|
|
There was a problem hiding this comment.
Suggested change
| sub_range = range(len(self.subplots)) | |
| ss_temp = { | |
| x: self.subplots[x] for x in sub_range if len(self.subplots[x]) > 1 | |
| } | |
| for k, v in ss_temp.items(): | |
| for x in v: | |
| _stacked_subplots_ind.setdefault(int(x), k) | |
| _stacked_subplots_offsets.append([0, 0]) | |
| for i, sub_plot in enumerate(self.subplots): | |
| if len(sub_plot) <= 1: | |
| continue | |
| for plot in sub_plot: | |
| _stacked_subplots_ind[int(plot)] = i | |
| _stacked_subplots_offsets.append([0, 0]) |
mroeschke
reviewed
Apr 23, 2025
Comment on lines
+686
to
+696
| @pytest.fixture(scope="class") | ||
| def BSS_data(): | ||
| return np.random.default_rng(3).integers(0, 100, 5) | ||
|
|
||
|
|
||
| @pytest.fixture(scope="class") | ||
| def BSS_df(BSS_data) -> DataFrame: | ||
| BSS_df = DataFrame( | ||
| {"A": BSS_data, "B": BSS_data[::-1], "C": BSS_data[0], "D": BSS_data[-1]} | ||
| ) | ||
| return BSS_df |
There was a problem hiding this comment.
Suggested change
| @pytest.fixture(scope="class") | |
| def BSS_data(): | |
| return np.random.default_rng(3).integers(0, 100, 5) | |
| @pytest.fixture(scope="class") | |
| def BSS_df(BSS_data) -> DataFrame: | |
| BSS_df = DataFrame( | |
| {"A": BSS_data, "B": BSS_data[::-1], "C": BSS_data[0], "D": BSS_data[-1]} | |
| ) | |
| return BSS_df | |
| @pytest.fixture | |
| def BSS_data(): | |
| return np.random.default_rng(3).integers(0, 100, 5) | |
| @pytest.fixture | |
| def BSS_df(BSS_data) -> DataFrame: | |
| return DataFrame( | |
| {"A": BSS_data, "B": BSS_data[::-1], "C": BSS_data[0], "D": BSS_data[-1]} | |
| ) |
Also what's the BBS abbreviation? It would be better to use a clearer name
mroeschke
reviewed
Apr 23, 2025
| sliced_df = subplot_sliced_by_source[i] | ||
| if i == 0: | ||
| # Checks that the bar chart starts y=0 | ||
| assert (sliced_df["y_coord"] == 0).all |
There was a problem hiding this comment.
Suggested change
| assert (sliced_df["y_coord"] == 0).all | |
| assert (sliced_df["y_coord"] == 0).all() |
?
mroeschke
reviewed
Apr 23, 2025
| ) | ||
|
|
||
|
|
||
| class TestBarSubplotStacked: |
There was a problem hiding this comment.
Could you remove the test class? We're moving away from using this style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Added check for when stacked and subplots are used in conjunction for bar plots. And logic dictating offsets for individual subplots to account for plots with non-concurrent columns being graphed.
Currently, does not take into account column order in subplot entry (eg: (A, B) vs (B, A)) when stacking