EHN: df.to_latex(escape=True) also escape index names
#61307
+32
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rhshadrach
requested changes
Apr 19, 2025
| @@ -824,6 +824,33 @@ def test_to_latex_escape_special_chars(self): | |||
| ) | |||
| assert result == expected | |||
|
|
|||
| def test_to_latex_escape_special_chars_in_index_names(self): | |||
| special_characters = ["&", "%", "$", "#", "_", "{", "}", "~", "^", "\\"] | |||
There was a problem hiding this comment.
Can you start the first line of the test with a reference to the issue:
# https://github.com/pandas-dev/pandas/issues/61309
| @@ -824,6 +824,33 @@ def test_to_latex_escape_special_chars(self): | |||
| ) | |||
| assert result == expected | |||
|
|
|||
| def test_to_latex_escape_special_chars_in_index_names(self): | |||
There was a problem hiding this comment.
I'm seeing this test pass on main.
There was a problem hiding this comment.
oops, my bad. fixed
|
cc @attack68 as the codeowner of styler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Stage 3. Part of an multi-stages effort: #57880 (comment)
Part 2 has a issue at #59324
But in the process of implementing, I realized the current implementation of
df.to_latex(escape)does not go throughstyler.to_latexbut to callstyler.format_index. This implementation follows the same flow. So maybe part 2 is not really relevant.